From c2a70414026143b7e8da5d56e229c950359a7ff4 Mon Sep 17 00:00:00 2001 From: Daria Phoebe Brashear Date: Fri, 10 Jan 2020 12:58:09 -0500 Subject: [PATCH] krb5_mk_ncred: clean enc_krb_cred_part before use the early exit case can try to free enc_krb_cred_part, which will be stack garbage. clear it before it's used. --- lib/krb5/mk_cred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/krb5/mk_cred.c b/lib/krb5/mk_cred.c index ec10a8a06..45ece8e02 100644 --- a/lib/krb5/mk_cred.c +++ b/lib/krb5/mk_cred.c @@ -141,6 +141,7 @@ _krb5_mk_ncred(krb5_context context, ; memset (&cred, 0, sizeof(cred)); + memset (&enc_krb_cred_part, 0, sizeof(enc_krb_cred_part)); cred.pvno = 5; cred.msg_type = krb_cred; ALLOC_SEQ(&cred.tickets, ncreds); @@ -148,7 +149,6 @@ _krb5_mk_ncred(krb5_context context, ret = krb5_enomem(context); goto out; } - memset (&enc_krb_cred_part, 0, sizeof(enc_krb_cred_part)); ALLOC_SEQ(&enc_krb_cred_part.ticket_info, ncreds); if (enc_krb_cred_part.ticket_info.val == NULL) { ret = krb5_enomem(context);