From c12ca129b688555b4b39120f5b309786c43106b1 Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Tue, 15 Sep 2020 15:24:29 -0500 Subject: [PATCH] httpkadmind: Fix FD leak Using `mkstemp()` is nice, but if you don't need the FD, then don't forget to close it! --- kdc/httpkadmind.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kdc/httpkadmind.c b/kdc/httpkadmind.c index 055e09e8c..f843809f1 100644 --- a/kdc/httpkadmind.c +++ b/kdc/httpkadmind.c @@ -990,6 +990,8 @@ make_keytab(kadmin_request_desc r) ret = errno; if (ret == 0) ret = krb5_kt_resolve(r->context, r->keytab_name, &r->keytab); + if (fd != -1) + (void) close(fd); return ret; }