From bf00a76951172b566c7cb02a48a6e4b75730cbc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Love=20H=C3=B6rnquist=20=C3=85strand?= Date: Mon, 9 May 2005 19:17:34 +0000 Subject: [PATCH] (find_func): Fix off-by-one and logic error. (external_passwd_quality): Improve messages. git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15106 ec53bebd-3082-4978-b11e-865c3cabbd6b --- lib/kadm5/password_quality.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/kadm5/password_quality.c b/lib/kadm5/password_quality.c index 2cd80880b..5763718a8 100644 --- a/lib/kadm5/password_quality.c +++ b/lib/kadm5/password_quality.c @@ -189,12 +189,12 @@ external_passwd_quality (krb5_context context, if (fgets(reply, sizeof(reply), error) == NULL) { snprintf(message, length, "external password quality " - "program fail without error"); + "program failed without error"); } else { reply[strcspn(reply, "\n")] = '\0'; snprintf(message, length, "External password quality " - "program fail: %s", reply); + "program failed: %s", reply); } fclose(out); @@ -420,7 +420,7 @@ find_func(krb5_context context, const char *name) p = strchr(name, ':'); if (p) { func = p + 1; - module = strndup(name, p - name - 1); + module = strndup(name, p - name); if (module == NULL) return NULL; } else @@ -440,7 +440,7 @@ find_func(krb5_context context, const char *name) /* Lets try try the builtin modules */ if (module == NULL || strcmp(module, "builtin") == 0) { for (f = builtin_verifier.funcs; f->name ; f++) - if (strcmp(name, f->name) == 0) { + if (strcmp(func, f->name) == 0) { if (module) free(module); return f;