From be1b8d4459d5f6608383379c07212d2c153beff3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Love=20H=C3=B6rnquist=20=C3=85strand?= <lha@kth.se>
Date: Sun, 29 Feb 2004 06:56:22 +0000
Subject: [PATCH] (create_random_entry): print error message on failure

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13410 ec53bebd-3082-4978-b11e-865c3cabbd6b
---
 kadmin/init.c | 39 ++++++++++++++++++++++++++++++---------
 1 file changed, 30 insertions(+), 9 deletions(-)

diff --git a/kadmin/init.c b/kadmin/init.c
index a377136d2..2a2b35577 100644
--- a/kadmin/init.c
+++ b/kadmin/init.c
@@ -47,6 +47,13 @@ create_random_entry(krb5_principal princ,
     int mask = 0;
     krb5_keyblock *keys;
     int n_keys, i;
+    char *name;
+
+    ret = krb5_unparse_name(context, princ, &name);
+    if (ret) {
+	krb5_warn(context, ret, "failed to unparse principal name");
+	return ret;
+    }
 
     memset(&ent, 0, sizeof(ent));
     ent.principal = princ;
@@ -63,26 +70,40 @@ create_random_entry(krb5_principal princ,
     mask |= KADM5_ATTRIBUTES;
 
     ret = kadm5_create_principal(kadm_handle, &ent, mask, "hemlig");
-    if(ret)
-	return ret;
+    if(ret) {
+	krb5_warn(context, ret, "create_random_entry(%s): randkey failed", 
+		  name);
+	goto out;
+    }
     ret = kadm5_randkey_principal(kadm_handle, princ, &keys, &n_keys);
-    if(ret)
-	return ret;
+    if(ret) {
+	krb5_warn(context, ret, "create_random_entry*%s): randkey failed",
+		  name);
+	goto out;
+    }
     for(i = 0; i < n_keys; i++)
 	krb5_free_keyblock_contents(context, &keys[i]);
     free(keys);
     ret = kadm5_get_principal(kadm_handle, princ, &ent, 
 			      KADM5_PRINCIPAL | KADM5_ATTRIBUTES);
-    if(ret)
-	return ret;
+    if(ret) {
+	krb5_warn(context, ret, "create_random_entry(%s): "
+		  "unable to get principal", name);
+	goto out;
+    }
     ent.attributes &= (~KRB5_KDB_DISALLOW_ALL_TIX);
     ent.kvno = 1;
     ret = kadm5_modify_principal(kadm_handle, &ent, 
 				 KADM5_ATTRIBUTES|KADM5_KVNO);
     kadm5_free_principal_ent (kadm_handle, &ent);
-    if(ret)
-	return ret;
-    return 0;
+    if(ret) {
+	krb5_warn(context, ret, "create_random_entry(%s): "
+		  "unable to modify principal", name);
+	goto out;
+    }
+ out:
+    free(name);
+    return ret;
 }
 
 static struct getargs args[] = {