From bd465edee24fa0a950d79aa3eac6cd237e58274b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Groenvall?= <bg@sics.se>
Date: Fri, 27 Feb 1998 17:22:21 +0000
Subject: [PATCH] Be carefull to preserve (issue_date, life) -> (StartTime,
 EndTime) -> (issue_date, life)

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@4477 ec53bebd-3082-4978-b11e-865c3cabbd6b
---
 lib/kafs/common.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/lib/kafs/common.c b/lib/kafs/common.c
index 048269965..f7fbff82a 100644
--- a/lib/kafs/common.c
+++ b/lib/kafs/common.c
@@ -75,17 +75,31 @@ kafs_settoken(const char *cell, uid_t uid, CREDENTIALS *c)
      */
     ct.AuthHandle = c->kvno;
     memcpy (ct.HandShakeKey, c->session, sizeof(c->session));
-    ct.ViceId = uid;	/* is this always valid? */
-    ct.BeginTimestamp = 1 + c->issue_date;
+    ct.ViceId = uid;
+    ct.BeginTimestamp = c->issue_date;
     ct.EndTimestamp = krb_life_to_time(c->issue_date, c->lifetime);
     if(ct.EndTimestamp < time(NULL))
 	return 0; /* don't store tokens that has expired (and possibly
 		     overwriting valid tokens)*/
 
 #define ODD(x) ((x) & 1)
-    /* If we don't know the numerical ID lifetime should be even? */
-    if (uid == 0 && ODD(ct.EndTimestamp - ct.BeginTimestamp))
-	ct.BeginTimestamp--;
+    /* According to Transarc conventions ViceId is valid iff
+     * (EndTimestamp - BeginTimestamp) is odd. By decrementing EndTime
+     * the transformations:
+     *
+     * (issue_date, life) -> (StartTime, EndTime) -> (issue_date, life)
+     * preserves the original values.
+     */
+    if (uid != 0)		/* valid ViceId */
+      {
+	if (!ODD(ct.EndTimestamp - ct.BeginTimestamp))
+	  ct.EndTimestamp--;
+      }
+    else			/* not valid ViceId */
+      {
+	if (ODD(ct.EndTimestamp - ct.BeginTimestamp))
+	  ct.EndTimestamp--;
+      }
 
     t = buf;
     /*