From b90732860a4ede602f4df623824c22d623335a9e Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Mon, 7 Oct 2013 13:57:03 -0500 Subject: [PATCH] libtommath: remove unnecessary comparison As pointed out by Steffen Jaeckel [https://github.com/sjaeckel], within bn_mp_prime_next_prime() t <= PRIME_SIZE as per the check at the top of the function. Remove the unnecessary comparison in a for loop conditional. Change-Id: I868bee1a7a019e0ab06bf2b81cc71cf66ca9acff --- lib/hcrypto/libtommath/bn_mp_prime_next_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hcrypto/libtommath/bn_mp_prime_next_prime.c b/lib/hcrypto/libtommath/bn_mp_prime_next_prime.c index db2f46ddb..8cd3ec2a5 100644 --- a/lib/hcrypto/libtommath/bn_mp_prime_next_prime.c +++ b/lib/hcrypto/libtommath/bn_mp_prime_next_prime.c @@ -142,7 +142,7 @@ int mp_prime_next_prime(mp_int *a, int t, int bbs_style) } /* is this prime? */ - for (x = 0; x < t && x < PRIME_SIZE; x++) { + for (x = 0; x < t; x++) { mp_set(&b, ltm_prime_tab[x]); if ((err = mp_prime_miller_rabin(a, &b, &res)) != MP_OKAY) { goto LBL_ERR;