From b84bdf213d9d2c62fb942c09729cf7276557374a Mon Sep 17 00:00:00 2001
From: Nicolas Williams <nico@cryptonector.com>
Date: Thu, 12 Mar 2015 21:20:09 -0400
Subject: [PATCH] krb5: improve comments in get_cred_kdc_capath_worker

Change-Id: I0d47ada32fdc9f7938d69d93022f1daac80d4e88
---
 lib/krb5/get_cred.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/lib/krb5/get_cred.c b/lib/krb5/get_cred.c
index 05d5ced16..cf40172bb 100644
--- a/lib/krb5/get_cred.c
+++ b/lib/krb5/get_cred.c
@@ -778,6 +778,10 @@ get_cred_kdc_capath_worker(krb5_context context,
     {
 	krb5_creds tgts;
 
+	/*
+	 * If we have krbtgt/server_realm@try_realm cached, use it and we're
+	 * done.
+	 */
 	ret = find_cred(context, ccache, tmp_creds.server,
 			*ret_tgts, &tgts);
 	if (ret == 0) {
@@ -811,7 +815,16 @@ get_cred_kdc_capath_worker(krb5_context context,
 	goto out;
     }
 
-    /* XXX this can loop forever */
+    /*
+     * XXX This can loop forever, plus we recurse, so we can't just keep a
+     * count here.  The count would have to get passed around by reference.
+     *
+     * The KDCs check for transit loops for us, and capath data is finite, so
+     * in fact we'll fall out of this loop at some point.  We should do our own
+     * transit loop checking (like get_cred_kdc_referral()), and we should
+     * impose a max number of iterations altogether.  But barring malicious or
+     * broken KDCs, this is good enough.
+     */
     while (1) {
 	heim_general_string tgt_inst;