From b4c0ef9970df739af89ea4b358f9026949ced03c Mon Sep 17 00:00:00 2001 From: Luke Howard Date: Sat, 26 Nov 2022 22:38:31 +1100 Subject: [PATCH] asn1: ensure quoting of default string values 5398425c introduced support for propagating ASN.1 default values to the emitted JSON, but it neglected to quote string values, which caused ASN.1 parsing errors. Correct this. --- lib/asn1/gen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/asn1/gen.c b/lib/asn1/gen.c index af543d966..06dc6bb70 100644 --- a/lib/asn1/gen.c +++ b/lib/asn1/gen.c @@ -1415,7 +1415,9 @@ define_type(int level, const char *name, const char *basename, Type *pt, Type *t if (m->defval) { switch (m->defval->type) { case stringvalue: - defvalp = m->defval->u.stringvalue; + if (asprintf(&defval, "\"%s\"", m->defval->u.stringvalue) < 0 || defval == NULL) + errx(1, "malloc"); + defvalp = defval; break; case integervalue: if (asprintf(&defval, "%lld", (long long)m->defval->u.integervalue) < 0 || defval == NULL)