From ad995f9b6987d47d243b2745236995c00d5c8ee7 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Wed, 4 Dec 2013 14:21:56 -0500 Subject: [PATCH] kx509: Prevent double free Patchset 750a09bca2183415be3ca3b8784e3417f484794b introduced the potential for a double free of 'name'. Change-Id: I23bd4ddb7d9b41cbb3948ab06245f4052b309971 --- kdc/kx509.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kdc/kx509.c b/kdc/kx509.c index fb393bd59..25861fbca 100644 --- a/kdc/kx509.c +++ b/kdc/kx509.c @@ -161,8 +161,6 @@ build_certificate(krb5_context context, if (ret) goto out; - krb5_xfree(name); - { hx509_certs certs; hx509_query *q; @@ -264,6 +262,9 @@ build_certificate(krb5_context context, if (ret) goto out; + /* cleanup on success */ + krb5_xfree(name); + return 0; out: if (name)