From ad8667192340a121c63bef80dec2b9f11afa48b3 Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Wed, 4 Jan 2023 16:22:12 -0600 Subject: [PATCH] kadm5: Fix return value non-checking --- lib/kadm5/ipropd_master.c | 5 +++-- lib/kadm5/log.c | 24 ++++++++++++------------ 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/lib/kadm5/ipropd_master.c b/lib/kadm5/ipropd_master.c index 2edba5c60..3d693bdfe 100644 --- a/lib/kadm5/ipropd_master.c +++ b/lib/kadm5/ipropd_master.c @@ -1195,10 +1195,11 @@ send_diffs(kadm5_server_context *server_context, slave *s, int log_fd, krb5_err(context, IPROPD_RESTART_SLOW, ENOMEM, "out of memory"); return; } - krb5_store_uint32(sp, FOR_YOU); + ret = krb5_store_uint32(sp, FOR_YOU); krb5_storage_free(sp); - ret = mk_priv_tail(context, s, &data); + if (ret == 0) + ret = mk_priv_tail(context, s, &data); krb5_data_free(&data); if (ret == 0) { /* Save the fast-path continuation */ diff --git a/lib/kadm5/log.c b/lib/kadm5/log.c index 4f66426c4..96d063eb9 100644 --- a/lib/kadm5/log.c +++ b/lib/kadm5/log.c @@ -843,19 +843,19 @@ kadm5_log_signal_master(kadm5_server_context *context) { kadm5_log_context *log_context = &context->log_context; #ifndef NO_UNIX_SOCKETS - sendto(log_context->socket_fd, - (void *)&log_context->version, - sizeof(log_context->version), - 0, - (struct sockaddr *)&log_context->socket_name, - sizeof(log_context->socket_name)); + (void) sendto(log_context->socket_fd, + (void *)&log_context->version, + sizeof(log_context->version), + 0, + (struct sockaddr *)&log_context->socket_name, + sizeof(log_context->socket_name)); #else - sendto(log_context->socket_fd, - (void *)&log_context->version, - sizeof(log_context->version), - 0, - log_context->socket_info->ai_addr, - log_context->socket_info->ai_addrlen); + (void) sendto(log_context->socket_fd, + (void *)&log_context->version, + sizeof(log_context->version), + 0, + log_context->socket_info->ai_addr, + log_context->socket_info->ai_addrlen); #endif }