From aa9be97d0d10e6ad25b781032d2e96c9cfe9c4c8 Mon Sep 17 00:00:00 2001 From: "Asanka C. Herath" Date: Wed, 24 Nov 2010 12:59:03 -0500 Subject: [PATCH] Windows: Always initialize buffers in config_reg --- lib/krb5/config_reg.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/krb5/config_reg.c b/lib/krb5/config_reg.c index ec0e27fb4..1e20aa7e2 100644 --- a/lib/krb5/config_reg.c +++ b/lib/krb5/config_reg.c @@ -87,11 +87,10 @@ _krb5_parse_reg_value_as_multi_string(krb5_context context, DWORD type, DWORD cb_data, char *separator) { LONG rcode = ERROR_MORE_DATA; - DWORD cb_alloc; - krb5_error_code code = 0; BYTE static_buffer[16384]; - BYTE *pbuffer; + BYTE *pbuffer = &static_buffer[0]; + DWORD cb_alloc = sizeof(static_buffer); char *ret_string = NULL; /* If we know a type and cb_data from a previous call to @@ -213,7 +212,7 @@ have_data: ret_string = (char *) pbuffer; pbuffer = NULL; } else { - ret_string = strdup(pbuffer); + ret_string = strdup((char *) pbuffer); } } break;