From a79b59ba27070a015479e8d981b7e685dbe34310 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 29 Aug 2017 07:24:35 +0200 Subject: [PATCH] kdc: fix dh->q allocation check in get_dh_param() Thanks to Doug Nazar for spotting this! BUG: https://bugzilla.samba.org/show_bug.cgi?id=12986 Signed-off-by: Stefan Metzmacher --- kdc/pkinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kdc/pkinit.c b/kdc/pkinit.c index 28333fc56..b9fa760fb 100644 --- a/kdc/pkinit.c +++ b/kdc/pkinit.c @@ -353,7 +353,7 @@ get_dh_param(krb5_context context, if (dhparam.q) { dh->q = integer_to_BN(context, "DH p-1 factor", dhparam.q); - if (dh->g == NULL) + if (dh->q == NULL) goto out; }