From 9ccc79c5b6adb77343b4c5d0dbd9938e08fcde34 Mon Sep 17 00:00:00 2001 From: Love Hornquist Astrand Date: Sat, 22 Aug 2009 10:52:22 -0700 Subject: [PATCH] Don't leak context if nsi_probe failes Deduced from valgrind log produced by Markus Moeller --- lib/gssapi/ntlm/acquire_cred.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/gssapi/ntlm/acquire_cred.c b/lib/gssapi/ntlm/acquire_cred.c index e4fb8ff21..3b4ed01eb 100644 --- a/lib/gssapi/ntlm/acquire_cred.c +++ b/lib/gssapi/ntlm/acquire_cred.c @@ -66,15 +66,13 @@ OM_uint32 _gss_ntlm_acquire_cred maj_stat = (*ctx->server->nsi_probe)(min_stat, ctx->ictx, name->domain); - - if (maj_stat) - return maj_stat; - { gss_ctx_id_t context = (gss_ctx_id_t)ctx; - _gss_ntlm_delete_sec_context(min_stat, &context, NULL); - *min_stat = 0; + OM_uint32 junk; + _gss_ntlm_delete_sec_context(&junk, &context, NULL); } + if (maj_stat) + return maj_stat; } if (cred_usage == GSS_C_BOTH || cred_usage == GSS_C_INITIATE) { ntlm_cred cred;