From 9794f022455752894f50548cb50dbb34a8c966cf Mon Sep 17 00:00:00 2001
From: Nicolas Williams <nico@twosigma.com>
Date: Thu, 23 Apr 2020 20:44:32 -0500
Subject: [PATCH] roken: fix valgrind leak noise

---
 lib/roken/detach.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/roken/detach.c b/lib/roken/detach.c
index 9fcb5fe6e..36e6cda1e 100644
--- a/lib/roken/detach.c
+++ b/lib/roken/detach.c
@@ -52,7 +52,7 @@ roken_detach_prep(int argc, char **argv, char *special_arg)
     pid_t child;
     char **new_argv;
     char buf[1];
-    char *fildes;
+    char fildes[21];
     int status;
 
     pipefds[0] = -1;
@@ -78,9 +78,9 @@ roken_detach_prep(int argc, char **argv, char *special_arg)
     fcntl(pipefds[1], F_SETFD, fcntl(pipefds[1], F_GETFD & ~(O_CLOEXEC)));
 #endif
 
-    if (asprintf(&fildes, "%d", pipefds[1]) == -1 ||
-        fildes == NULL)
-        err(1, "failed to setup to detach daemon (_dup failed)");
+    if (snprintf(fildes, sizeof(fildes), "%d", pipefds[1]) >= sizeof(fildes))
+        err(1, "failed to setup to detach daemon (fd number %d too large)",
+            pipefds[1]);
 
     new_argv[0] = argv[0];
     new_argv[1] = special_arg;