From 892a1ffcaad98157e945c540b81f65edb14d29bd Mon Sep 17 00:00:00 2001
From: Luke Howard <lukeh@padl.com>
Date: Fri, 27 Aug 2021 11:44:21 +1000
Subject: [PATCH] kdc: KRB5KDC_ERR_{C,S}_PRINCIPAL_UNKNOWN if missing field

If missing cname or sname in AS-REQ, return KRB5KDC_ERR_C_PRINCIPAL_UNKNOWN and
KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN. This matches MIT behaviour.
---
 kdc/kerberos5.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kdc/kerberos5.c b/kdc/kerberos5.c
index 12e19b599..f81266233 100644
--- a/kdc/kerberos5.c
+++ b/kdc/kerberos5.c
@@ -1973,7 +1973,7 @@ _kdc_as_rep(astgs_request_t r)
 	flags |= HDB_F_CANON;
 
     if (b->sname == NULL) {
-	ret = KRB5KRB_ERR_GENERIC;
+	ret = KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN;
 	_kdc_set_e_text(r, "No server in request");
 	goto out;
     }
@@ -1989,7 +1989,7 @@ _kdc_as_rep(astgs_request_t r)
     }
 
     if (b->cname == NULL) {
-	ret = KRB5KRB_ERR_GENERIC;
+	ret = KRB5KDC_ERR_C_PRINCIPAL_UNKNOWN;
 	_kdc_set_e_text(r, "No client in request");
 	goto out;
     }