From 8456183c48aa1a4112dafe1279c3ee1a01a64ef5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Love=20H=C3=B6rnquist=20=C3=85strand?= Date: Wed, 6 Jun 2007 22:17:17 +0000 Subject: [PATCH] rename functions, leaks less memory and more paranoia. git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@20945 ec53bebd-3082-4978-b11e-865c3cabbd6b --- lib/hx509/ks_keychain.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/hx509/ks_keychain.c b/lib/hx509/ks_keychain.c index 076115fa8..fb7895988 100644 --- a/lib/hx509/ks_keychain.c +++ b/lib/hx509/ks_keychain.c @@ -191,8 +191,9 @@ static const RSA_METHOD kc_rsa_pkcs1_method = { }; static int -private_key(hx509_context context, SecKeychainItemRef itemRef, - hx509_cert cert) +set_private_key(hx509_context context, + SecKeychainItemRef itemRef, + hx509_cert cert) { struct kc_rsa *kc; hx509_private_key key; @@ -215,7 +216,7 @@ private_key(hx509_context context, SecKeychainItemRef itemRef, /* Argh, fake modulus since OpenSSL API is on crack */ { - SecKeychainAttributeList *attrs; + SecKeychainAttributeList *attrs = NULL; uint32_t size; void *data; @@ -233,6 +234,7 @@ private_key(hx509_context context, SecKeychainItemRef itemRef, data = malloc(kc->keysize); memset(data, 0xe0, kc->keysize); BN_bin2bn(data, kc->keysize, rsa->n); + free(data); } rsa->e = NULL; @@ -426,8 +428,7 @@ keychain_iter(hx509_context context, ret = EINVAL; goto out; } - - private_key(context, itemRef, *cert); + set_private_key(context, itemRef, *cert); } out: