From 7ae429298674f2f4035554c275ef548c23f412fd Mon Sep 17 00:00:00 2001
From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Sat, 24 Sep 2022 11:03:46 +1200
Subject: [PATCH] lib/krb5: Fix leak in error path

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
---
 lib/krb5/pac.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/krb5/pac.c b/lib/krb5/pac.c
index f27976869..122120c10 100644
--- a/lib/krb5/pac.c
+++ b/lib/krb5/pac.c
@@ -980,6 +980,7 @@ verify_logonname(krb5_context context,
     }
     ret = krb5_storage_read(sp, s, len);
     if (ret != len) {
+	free(s);
 	krb5_storage_free(sp);
 	krb5_set_error_message(context, EINVAL, "Failed to read PAC logon name");
 	return EINVAL;
@@ -992,8 +993,10 @@ verify_logonname(krb5_context context,
 	unsigned int flags = WIND_RW_LE;
 
 	ucs2 = malloc(sizeof(ucs2[0]) * ucs2len);
-	if (ucs2 == NULL)
+	if (ucs2 == NULL) {
+	    free(s);
 	    return krb5_enomem(context);
+	}
 
 	ret = wind_ucs2read(s, len, &flags, ucs2, &ucs2len);
 	free(s);