From 6b5feba91d6b78a822a3ce34e10a6e4507fb256e Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Tue, 9 Mar 2021 12:20:17 -0600 Subject: [PATCH] asn1: Fix printing of bit string named members Properly print commas between members. --- lib/asn1/template.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/asn1/template.c b/lib/asn1/template.c index 1c601ff44..437b1b7df 100644 --- a/lib/asn1/template.c +++ b/lib/asn1/template.c @@ -2682,11 +2682,13 @@ _asn1_print(const struct asn1_template *t, bmember += belements; r = rk_strpoolprintf(r, "%s[", indents ? indents : ""); while (r && belements) { - if (!first) - r = rk_strpoolprintf(r, ","); - if (r && _asn1_bmember_isset_bit(data, bmember->offset, size)) + if (r && _asn1_bmember_isset_bit(data, bmember->offset, size)) { + if (!first) + r = rk_strpoolprintf(r, ","); + first = 0; r = rk_strpoolprintf(r, "%s\"%s\"", indents ? indents : "", (const char *)bmember->ptr); + } belements--; bmember--; } if (r)