From 5407ae308c567aa438977256ecd6610d34744b39 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Love=20H=C3=B6rnquist=20=C3=85strand?= <lha@kth.se>
Date: Sat, 21 Oct 2006 19:42:20 +0000
Subject: [PATCH] Try to not leak memory.

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@18780 ec53bebd-3082-4978-b11e-865c3cabbd6b
---
 lib/hx509/cms.c    | 19 ++++++++++---------
 lib/hx509/hxtool.c |  1 +
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/lib/hx509/cms.c b/lib/hx509/cms.c
index 5d3e0778a..067054cca 100644
--- a/lib/hx509/cms.c
+++ b/lib/hx509/cms.c
@@ -367,12 +367,15 @@ hx509_cms_unenvelope(hx509_context context,
 	
 	if (params) {
 	    ret = hx509_crypto_set_params(context, crypto, params, &ivec);
-	    if (ret)
+	    if (ret) {
+		hx509_crypto_destroy(crypto);
 		goto out;
+	    }
 	}
 
 	ret = hx509_crypto_set_key_data(crypto, key.data, key.length);
 	if (ret) {
+	    hx509_crypto_destroy(crypto);
 	    hx509_set_error_string(context, 0, ret,
 				   "Failed to set key for decryption "
 				   "of EnvelopedData");
@@ -384,6 +387,7 @@ hx509_cms_unenvelope(hx509_context context,
 				   enccontent->length,
 				   ivec.length ? &ivec : NULL,
 				   content);
+	hx509_crypto_destroy(crypto);
 	if (ret) {
 	    hx509_set_error_string(context, 0, ret,
 				   "Failed to decrypt EnvelopedData");
@@ -393,6 +397,7 @@ hx509_cms_unenvelope(hx509_context context,
 
 out:
 
+    free_EnvelopedData(&ed);
     der_free_octet_string(&key);
     if (ivec.length)
 	der_free_octet_string(&ivec);
@@ -416,7 +421,7 @@ hx509_cms_envelope_1(hx509_context context,
     KeyTransRecipientInfo *ri;
     heim_octet_string ivec;
     heim_octet_string key;
-    hx509_crypto crypto;
+    hx509_crypto crypto = NULL;
     EnvelopedData ed;
     size_t size;
     int ret;
@@ -441,7 +446,6 @@ hx509_cms_envelope_1(hx509_context context,
     if (ret) {
 	hx509_set_error_string(context, 0, ret,
 			       "Create random key for EnvelopedData content");
-	hx509_crypto_destroy(crypto);
 	goto out;
     }
 
@@ -453,7 +457,6 @@ hx509_cms_envelope_1(hx509_context context,
     if (ret) {
 	hx509_set_error_string(context, 0, ret,
 			       "Failed to encrypt EnvelopedData content");
-	hx509_crypto_destroy(crypto);
 	goto out;
     }
 
@@ -465,7 +468,6 @@ hx509_cms_envelope_1(hx509_context context,
 	    hx509_set_error_string(context, 0, ret,
 				   "Failed to set crypto oid "
 				   "for EnvelopedData");
-	    hx509_crypto_destroy(crypto);
 	    goto out;
 	}	
 	ALLOC(enc_alg->parameters, 1);
@@ -474,7 +476,6 @@ hx509_cms_envelope_1(hx509_context context,
 	    hx509_set_error_string(context, 0, ret,
 				   "Failed to allocate crypto paramaters "
 				   "for EnvelopedData");
-	    hx509_crypto_destroy(crypto);
 	    goto out;
 	}
 
@@ -482,7 +483,6 @@ hx509_cms_envelope_1(hx509_context context,
 				      crypto,
 				      &ivec,
 				      enc_alg->parameters);
-	hx509_crypto_destroy(crypto);
 	if (ret) {
 	    goto out;
 	}
@@ -546,9 +546,10 @@ hx509_cms_envelope_1(hx509_context context,
 	_hx509_abort("internal ASN.1 encoder error");
 
 out:
-    if (ret) {
+    if (crypto)
+	hx509_crypto_destroy(crypto);
+    if (ret)
 	der_free_octet_string(content);
-    }
     der_free_octet_string(&key);
     der_free_octet_string(&ivec);
     free_EnvelopedData(&ed);
diff --git a/lib/hx509/hxtool.c b/lib/hx509/hxtool.c
index fbe44eece..f0ae22474 100644
--- a/lib/hx509/hxtool.c
+++ b/lib/hx509/hxtool.c
@@ -236,6 +236,7 @@ cms_create_sd(struct cms_create_sd_options *opt, int argc, char **argv)
     hx509_certs_free(&anchors);
     hx509_certs_free(&pool);
     hx509_certs_free(&store);
+    hx509_cert_free(cert);
     _hx509_unmap_file(p, sz);
     hx509_lock_free(lock);