From 3c2b7b865bc8bf52bf61d9cc354bd08569330bf2 Mon Sep 17 00:00:00 2001
From: Taylor R Campbell <campbell+heimdal@mumble.net>
Date: Tue, 20 Jun 2023 11:10:21 +0000
Subject: [PATCH] kdc: Note strict aliasing violations.

---
 kdc/default_config.c       | 4 ++--
 kdc/test_csr_authorizer.c  | 4 ++--
 kdc/test_kdc_ca.c          | 4 ++--
 kdc/test_token_validator.c | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/kdc/default_config.c b/kdc/default_config.c
index eddf6cd0a..1bb76bc5b 100644
--- a/kdc/default_config.c
+++ b/kdc/default_config.c
@@ -58,11 +58,11 @@ load_kdc_plugins_once(void *ctx)
     char **cfdirs;
 
     cfdirs = krb5_config_get_strings(context, NULL, "kdc", "plugin_dir", NULL);
-    if (cfdirs)
+    if (cfdirs)			/* XXX strict aliasing violation */
         dirs = (const char * const *)cfdirs;
 #endif
 
-    _krb5_load_plugins(context, "kdc", (const char **)dirs);
+    _krb5_load_plugins(context, "kdc", dirs);
 
 #ifndef _WIN32
     krb5_config_free_strings(cfdirs);
diff --git a/kdc/test_csr_authorizer.c b/kdc/test_csr_authorizer.c
index 200af16c1..c9bae8297 100644
--- a/kdc/test_csr_authorizer.c
+++ b/kdc/test_csr_authorizer.c
@@ -149,11 +149,11 @@ load_plugins(krb5_context context)
     char **cfdirs;
 
     cfdirs = krb5_config_get_strings(context, NULL, "kdc", "plugin_dir", NULL);
-    if (cfdirs)
+    if (cfdirs)			/* XXX strict aliasing violation */
         dirs = (const char * const *)cfdirs;
 #endif
 
-    _krb5_load_plugins(context, "kdc", (const char **)dirs);
+    _krb5_load_plugins(context, "kdc", dirs);
 
 #ifndef _WIN32
     krb5_config_free_strings(cfdirs);
diff --git a/kdc/test_kdc_ca.c b/kdc/test_kdc_ca.c
index 4d80c96a0..66ee5d115 100644
--- a/kdc/test_kdc_ca.c
+++ b/kdc/test_kdc_ca.c
@@ -57,11 +57,11 @@ load_plugins(krb5_context context)
     char **cfdirs;
 
     cfdirs = krb5_config_get_strings(context, NULL, "kdc", "plugin_dir", NULL);
-    if (cfdirs)
+    if (cfdirs)			/* XXX strict aliasing violation */
         dirs = (const char * const *)cfdirs;
 #endif
 
-    _krb5_load_plugins(context, "kdc", (const char **)dirs);
+    _krb5_load_plugins(context, "kdc", dirs);
 
 #ifndef _WIN32
     krb5_config_free_strings(cfdirs);
diff --git a/kdc/test_token_validator.c b/kdc/test_token_validator.c
index 2e4e9dca3..9c538469b 100644
--- a/kdc/test_token_validator.c
+++ b/kdc/test_token_validator.c
@@ -47,11 +47,11 @@ load_plugins(krb5_context context)
     char **cfdirs;
 
     cfdirs = krb5_config_get_strings(context, NULL, "kdc", "plugin_dir", NULL);
-    if (cfdirs)
+    if (cfdirs)			/* XXX strict aliasing violation */
         dirs = (const char * const *)cfdirs;
 #endif
 
-    _krb5_load_plugins(context, "kdc", (const char **)dirs);
+    _krb5_load_plugins(context, "kdc", dirs);
 
 #ifndef _WIN32
     krb5_config_free_strings(cfdirs);