From 2f7a9d9530d9b427494efb9e51ce99a29a0da66a Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sat, 15 Jun 2024 09:35:05 +0100 Subject: [PATCH] gssapi: Fix ordering logic in _gssapi_msg_order_check A typo in _gssapi_msg_order_check means that sequence numbers received out of sequence are not correctly added to the internal order array. --- lib/gssapi/krb5/sequence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/gssapi/krb5/sequence.c b/lib/gssapi/krb5/sequence.c index 2e0e7b20f..56ce447f5 100644 --- a/lib/gssapi/krb5/sequence.c +++ b/lib/gssapi/krb5/sequence.c @@ -188,7 +188,7 @@ _gssapi_msg_order_check(struct gss_msg_order *o, OM_uint32 seq_num) for (i = 0; i < o->length - 1; i++) { if (o->elem[i] == seq_num) return GSS_S_DUPLICATE_TOKEN; - if (o->elem[i + 1] < seq_num && o->elem[i] < seq_num) { + if (o->elem[i + 1] < seq_num && o->elem[i] > seq_num) { elem_insert(o, i, seq_num); if (r) return GSS_S_COMPLETE;