From 2b9b701dc413af293fd8b0aad2facccaaf5ffb8a Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Thu, 6 Jan 2022 16:21:55 -0600 Subject: [PATCH] gss: Fix warnings (from be708ca3cf) --- lib/gssapi/krb5/name_attrs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/gssapi/krb5/name_attrs.c b/lib/gssapi/krb5/name_attrs.c index 0592f1a25..d932650ef 100644 --- a/lib/gssapi/krb5/name_attrs.c +++ b/lib/gssapi/krb5/name_attrs.c @@ -361,6 +361,7 @@ _gsskrb5_get_name_attribute(OM_uint32 *minor_status, int64_t n; /* Output a specific AD element from the ticket or authenticator */ + krb5_data_zero(&data); if ((s = strndup(frag.value, frag.length)) == NULL) { *minor_status = ENOMEM; return GSS_S_FAILURE; @@ -385,7 +386,7 @@ _gsskrb5_get_name_attribute(OM_uint32 *minor_status, GSSAPI_KRB5_INIT(&context); kret = ENOENT; - if (ticket->authorization_data) { + if (ticket && ticket->authorization_data) { kret = _krb5_get_ad(context, ticket->authorization_data, NULL, n, value ? &data : NULL); @@ -400,7 +401,7 @@ _gsskrb5_get_name_attribute(OM_uint32 *minor_status, if (kret == ENOENT && nameattrs->authenticator_ad && n != KRB5_AUTHDATA_KDC_ISSUED && n != KRB5_AUTHDATA_WIN2K_PAC) { - kret = _krb5_get_ad(context, ticket->authorization_data, + kret = _krb5_get_ad(context, nameattrs->authenticator_ad, NULL, n, value ? &data : NULL); }