From 2a7b4852750797d9f043506b898b9a6684047bee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Love=20H=C3=B6rnquist=20=C3=85strand?= Date: Mon, 10 Apr 2006 08:58:53 +0000 Subject: [PATCH] (krb5_string_to_key_derived): deref after NULL check. Coverity NetBSD CID#2367 git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@17034 ec53bebd-3082-4978-b11e-865c3cabbd6b --- lib/krb5/crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/krb5/crypto.c b/lib/krb5/crypto.c index 65358d14f..fa5bd7cdc 100644 --- a/lib/krb5/crypto.c +++ b/lib/krb5/crypto.c @@ -4096,7 +4096,7 @@ krb5_string_to_key_derived(krb5_context context, struct encryption_type *et = _find_enctype(etype); krb5_error_code ret; struct key_data kd; - size_t keylen = et->keytype->bits / 8; + size_t keylen; u_char *tmp; if(et == NULL) { @@ -4104,6 +4104,8 @@ krb5_string_to_key_derived(krb5_context context, etype); return KRB5_PROG_ETYPE_NOSUPP; } + keylen = et->keytype->bits / 8; + ALLOC(kd.key, 1); if(kd.key == NULL) { krb5_set_error_string (context, "malloc: out of memory");