From 244e0b3971a01596d38a9277dd5659dae79515b5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Love=20H=C3=B6rnquist=20=C3=85strand?= <lha@kth.se>
Date: Wed, 9 Mar 2005 23:28:10 +0000
Subject: [PATCH] do error handling and catch programmers errors

git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14631 ec53bebd-3082-4978-b11e-865c3cabbd6b
---
 lib/krb5/pkinit.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/krb5/pkinit.c b/lib/krb5/pkinit.c
index fe29279b0..d9b12b661 100644
--- a/lib/krb5/pkinit.c
+++ b/lib/krb5/pkinit.c
@@ -711,7 +711,9 @@ pk_mk_padata(krb5_context context,
 
 	memset(&req_19, 0, sizeof(req_19));
 
-	copy_ContentInfo(&content_info, &req_19.signedAuthPack);
+	ret = copy_ContentInfo(&content_info, &req_19.signedAuthPack);
+	if (ret)
+	    goto out;
 	req_19.kdcCert = NULL;
 	req_19.trustedCertifiers = NULL;
 	req_19.encryptionCert = NULL;
@@ -721,13 +723,14 @@ pk_mk_padata(krb5_context context,
 
 	free_PA_PK_AS_REQ_19(&req_19);
 
-    } else {
+    } else if (compat & COMPAT_25) {
 
 	pa_type = KRB5_PADATA_PK_AS_REQ;
 	ASN1_MALLOC_ENCODE(PA_PK_AS_REQ, buf.data, buf.length,
 			   &req, &size, ret);
 
-    }
+    } else
+	krb5_abortx(context, "internal pkinit error");
     if (ret) {
 	krb5_set_error_string(context, "PA-PK-AS-REQ %d", ret);
 	goto out;