From 20b2dda743bdde2b34876b3259f9a85395a18a9c Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Sat, 31 Dec 2022 00:54:03 -0600 Subject: [PATCH] kdc: Quiet a static analyzer warning --- kdc/kerberos5.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/kdc/kerberos5.c b/kdc/kerberos5.c index 71f379e09..a11823c21 100644 --- a/kdc/kerberos5.c +++ b/kdc/kerberos5.c @@ -2038,13 +2038,11 @@ get_local_tgs(krb5_context context, KRB5_TGS_NAME, realm, NULL); - if (ret) - return ret; + if (ret == 0) + ret = _kdc_db_fetch(context, config, tgs_name, + HDB_F_GET_KRBTGT, NULL, krbtgtdb, krbtgt); - ret = _kdc_db_fetch(context, config, tgs_name, - HDB_F_GET_KRBTGT, NULL, krbtgtdb, krbtgt); krb5_free_principal(context, tgs_name); - return ret; }