From 079088e54314bc952bf23758235b5d2e8b2b79a2 Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Fri, 23 Jun 2023 12:43:41 +1200 Subject: [PATCH] kdc: Fix incorrect log message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ‘list.len’ can be equal to zero. Signed-off-by: Joseph Sutton --- kdc/pkinit.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kdc/pkinit.c b/kdc/pkinit.c index 7a151fa1b..33c245483 100644 --- a/kdc/pkinit.c +++ b/kdc/pkinit.c @@ -1616,8 +1616,12 @@ match_ms_upn_san(krb5_context context, goto out; if (list.len != 1) { - kdc_log(context, config, 0, - "More than one PKINIT MS UPN SAN"); + if (list.len) + kdc_log(context, config, 0, + "More than one PKINIT MS UPN SAN"); + else + kdc_log(context, config, 0, + "No PKINIT MS UPN SAN"); ret = KRB5_KDC_ERR_CLIENT_NAME_MISMATCH; goto out; }