mugiten/mugiten
1
0
Fork 0
Code Issues 94 Pull Requests Packages Releases 4 Activity

history: fix missing date dividers

Browse Source 
bug introduced in 4a7b28ad68
This commit is contained in:
Oystein Kristoffer Tveit
2025-12-19 12:04:11 +09:00
parent 8a98f28ff4
commit f89b233893
1 changed files with 41 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
lib/screens/history.dart
View File

@@ -70,54 +70,55 @@ class _HistoryViewState extends State<HistoryView> {
Expanded(
child: PagingListener(
controller: _pagingController,
builder: (context, state, fetchNextPage) =>
PagedListView<int, HistoryEntry?>.separated(
state: state,
fetchNextPage: fetchNextPage,
separatorBuilder: (context, index) {
if (index == 0) {
final firstItemDate =
_pagingController.items![1]!.lastTimestamp;
return _dateDivider(firstItemDate);
}
builder: (context, state, fetchNextPage) => PagedListView<int, HistoryEntry?>.separated(
state: state,
fetchNextPage: fetchNextPage,
separatorBuilder: (context, index) {
// The first item in _pagingController.items is a dummy shrinkbox,
// we always insert a date divider before it with the date of the next entry.
//
// We know this entry always exists, because we set noItemsFoundIndicatorBuilder below,
// which ensures this code is never called with an empty list.
if (index == 0) {
final firstItemDate =
_pagingController.items![1]!.lastTimestamp;
return _dateDivider(firstItemDate);
}
if (_pagingController.items!.length > index) {
return _divider();
}
final data = _pagingController.items!;
final data = _pagingController.items!;
final HistoryEntry search = data[index]!;
final HistoryEntry search = data[index]!;
// Previous in the sense of time, but it is the next item in the list.
final HistoryEntry? previousSearch =
data.length > index + 1 ? data[index + 1] : null;
// Previous in the sense of time, but it is the next item in the list.
final HistoryEntry? previousSearch =
data.length > index + 1 ? data[index + 1] : null;
if (previousSearch != null &&
!dateIsEqual(
search.lastTimestamp,
previousSearch.lastTimestamp,
)) {
return _dateDivider(previousSearch.lastTimestamp);
}
if (previousSearch != null &&
!dateIsEqual(
search.lastTimestamp,
previousSearch.lastTimestamp,
)) {
return _dateDivider(previousSearch.lastTimestamp);
}
return _divider();
},
builderDelegate: PagedChildBuilderDelegate<HistoryEntry?>(
invisibleItemsThreshold: invisibleItemsThreshold,
itemBuilder: (context, entry, index) => index == 0
? SizedBox.shrink()
: HistoryEntryTile(
entry: entry!,
objectKey: entry.id,
onDelete: () => _pagingController.refresh(),
),
noItemsFoundIndicatorBuilder: (context) => const Center(
child: Text(
'The history is empty.\nTry searching for something!',
return _divider();
},
builderDelegate: PagedChildBuilderDelegate<HistoryEntry?>(
invisibleItemsThreshold: invisibleItemsThreshold,
itemBuilder: (context, entry, index) => index == 0
? SizedBox.shrink()
: HistoryEntryTile(
entry: entry!,
objectKey: entry.id,
onDelete: () => _pagingController.refresh(),
),
),
noItemsFoundIndicatorBuilder: (context) => const Center(
child: Text(
'The history is empty.\nTry searching for something!',
),
),
),
),
),
),
],