From 5fed94ef27c48fd5c15da00c021af68cd1426c8d Mon Sep 17 00:00:00 2001
From: Felix Albrigtsen <felix@albrigtsen.it>
Date: Sun, 6 Oct 2024 02:58:51 +0200
Subject: [PATCH] flake: Replace nixpkgs overrides with cleaner ones

---
 flake.lock                         | 36 +++++++++++++++---------------
 flake.nix                          | 25 ++++++++-------------
 hosts/challenger/configuration.nix |  1 +
 hosts/felixalbpc/home.nix          |  2 +-
 4 files changed, 29 insertions(+), 35 deletions(-)

diff --git a/flake.lock b/flake.lock
index 67bfb9d..e452c4a 100644
--- a/flake.lock
+++ b/flake.lock
@@ -173,6 +173,22 @@
         "type": "github"
       }
     },
+    "nixpkgs-unstable": {
+      "locked": {
+        "lastModified": 1728018373,
+        "narHash": "sha256-NOiTvBbRLIOe5F6RbHaAh6++BNjsb149fGZd1T4+KBg=",
+        "owner": "NixOS",
+        "repo": "nixpkgs",
+        "rev": "bc947f541ae55e999ffdb4013441347d83b00feb",
+        "type": "github"
+      },
+      "original": {
+        "owner": "NixOS",
+        "ref": "nixos-unstable",
+        "repo": "nixpkgs",
+        "type": "github"
+      }
+    },
     "nixpkgs_2": {
       "locked": {
         "lastModified": 1698318101,
@@ -214,8 +230,8 @@
         "nix-minecraft": "nix-minecraft",
         "nixpkgs": "nixpkgs_3",
         "nixpkgs-2211": "nixpkgs-2211",
-        "sops-nix": "sops-nix",
-        "unstable": "unstable"
+        "nixpkgs-unstable": "nixpkgs-unstable",
+        "sops-nix": "sops-nix"
       }
     },
     "sops-nix": {
@@ -253,22 +269,6 @@
         "repo": "default",
         "type": "github"
       }
-    },
-    "unstable": {
-      "locked": {
-        "lastModified": 1726755586,
-        "narHash": "sha256-PmUr/2GQGvFTIJ6/Tvsins7Q43KTMvMFhvG6oaYK+Wk=",
-        "owner": "NixOS",
-        "repo": "nixpkgs",
-        "rev": "c04d5652cfa9742b1d519688f65d1bbccea9eb7e",
-        "type": "github"
-      },
-      "original": {
-        "owner": "NixOS",
-        "ref": "nixos-unstable",
-        "repo": "nixpkgs",
-        "type": "github"
-      }
     }
   },
   "root": "root",
diff --git a/flake.nix b/flake.nix
index b4a19b9..74945d9 100644
--- a/flake.nix
+++ b/flake.nix
@@ -3,7 +3,7 @@
 
   inputs = {
     nixpkgs.url = "github:NixOS/nixpkgs/nixos-24.05";
-    unstable.url = "github:NixOS/nixpkgs/nixos-unstable";
+    nixpkgs-unstable.url = "github:NixOS/nixpkgs/nixos-unstable";
     nixpkgs-2211.url = "https://github.com/NixOS/nixpkgs/archive/34bfa9403e42eece93d1a3740e9d8a02fceafbca.tar.gz"; # old nixpgks for e.g. remmina
 
     nix-darwin.url = "github:lnl7/nix-darwin/master";
@@ -29,28 +29,21 @@
     , nix-darwin
     , nixpkgs
     , nixpkgs-2211
+    , nixpkgs-unstable
     , sops-nix
-    , unstable
     , extra-config
   , ... }@inputs:
     let
       pkgs-overlay = final: prev: {
-        unstable = unstable.legacyPackages.${prev.system};
-        nixpkgs-2211 = nixpkgs-2211.legacyPackages.${prev.system};
-
-        python311 = prev.python311.override {
-          packageOverrides = self: super: {
-            # k5test is broken on darwin, as of 24.05
-            gssapi = super.gssapi.overrideAttrs (old: {
-              doInstallCheck = false;
-            });
-          };
+        unstable = import nixpkgs-unstable {
+          system = prev.system;
+          config.allowUnfree = true;
         };
 
-        tlclient = final.unstable.tlclient.overrideAttrs (finalAttrs: previousAttrs: {
-          # nixpkgs.config.allowUnfreePredicate doesn't work for the unstable overlay, as it is a different "nixpkgs"
-          meta.license.free = true;
-        });
+        nixpkgs-2211 = import nixpkgs-2211 {
+          system = prev.system;
+          config.allowUnfree = true;
+        };
       };
     in
     {
diff --git a/hosts/challenger/configuration.nix b/hosts/challenger/configuration.nix
index 9239ec4..6f89636 100644
--- a/hosts/challenger/configuration.nix
+++ b/hosts/challenger/configuration.nix
@@ -39,6 +39,7 @@
   environment.variables = { EDITOR = "vim"; };
   environment.systemPackages = with pkgs; [
     zfs
+    unstable.ncdu
   ];
 
   virtualisation.docker.enable = true;
diff --git a/hosts/felixalbpc/home.nix b/hosts/felixalbpc/home.nix
index 157d0a7..bd9dee5 100644
--- a/hosts/felixalbpc/home.nix
+++ b/hosts/felixalbpc/home.nix
@@ -26,7 +26,7 @@ in {
     openstackclient
     pwgen
     rofi-rbw-x11
-    tlclient
+    unstable.tlclient
     traceroute
     w3m