From 003474df4c183f265227c81d9ba57b459cae4daf Mon Sep 17 00:00:00 2001
From: Adrian Gunnar Lauterer <adrian@lauterer.it>
Date: Fri, 12 Apr 2024 11:41:33 +0200
Subject: [PATCH] samba + base fix i guess

---
 profiles/base.nix |  3 +++
 services/smb.nix  | 16 ++++++----------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/profiles/base.nix b/profiles/base.nix
index e7987bb..ced7ec4 100644
--- a/profiles/base.nix
+++ b/profiles/base.nix
@@ -15,6 +15,9 @@ imports =
       git
       rsync
       ripgrep
+      htop
+      bottom
+      foot.terminfo
       tailscale
     ];
 
diff --git a/services/smb.nix b/services/smb.nix
index e90304a..944ff05 100644
--- a/services/smb.nix
+++ b/services/smb.nix
@@ -17,9 +17,9 @@ services.samba = {
     min protocol = SMB3_00
     server smb encrypt = required
     # note: localhost is the ipv6 localhost ::1
-    hosts allow = 192.168.1. 127.0.0.1 localhost 100.
+    hosts allow = 192.168.1. 192.168.0. 127.0.0.1 localhost 100.0.0.0/255.0.0.0 
     hosts deny = 0.0.0.0/0
-    guest account = guest
+    guest account = nobody
     map to guest = bad user
   '';
   shares = {
@@ -35,14 +35,13 @@ services.samba = {
    # };
     Backup = {
       path = "/Main/Backup";
-      "valid users" = "gunalx";
+      browseable = "yes";
       "force user" = "gunalx";
       "force group" = "gunalx";
-      browseable = "yes";
       "read only" = "no";
-      "guest ok" = "yes";
-      "create mask" = "0777";
-      "directory mask" = "0777";
+      "guest ok" = "no";
+      "create mask" = "0644";
+      "directory mask" = "0755";
     };
   };
 };
@@ -56,9 +55,6 @@ services.samba-wsdd = {
 networking.firewall.allowPing = true;
 
 
-
-
-
 #services.avahi.openfirewall = true;
 services.avahi = {
     enable = true;