From f7fcc2359b34c83e0ee808c1e6a7862409db1d3e Mon Sep 17 00:00:00 2001 From: Adrian G L Date: Thu, 2 Oct 2025 12:05:57 +0200 Subject: [PATCH 1/2] fix: correct glm::mat3 usage and add missing argument in draw_scene call --- src/main.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main.rs b/src/main.rs index ca3d4d8..e92ed95 100644 --- a/src/main.rs +++ b/src/main.rs @@ -149,14 +149,18 @@ unsafe fn draw_scene(node: &scene_graph::SceneNode, transform_loc: i32, normal_l let mvp = view_projection * new_transform; gl::UniformMatrix4fv(transform_loc, 1, gl::FALSE, mvp.as_ptr()); let nm4 = glm::transpose(&glm::inverse(&new_transform)); - let normal_matrix = glm::mat3(&nm4); + let normal_matrix = glm::mat3( + nm4[(0,0)], nm4[(0,1)], nm4[(0,2)], + nm4[(1,0)], nm4[(1,1)], nm4[(1,2)], + nm4[(2,0)], nm4[(2,1)], nm4[(2,2)], + ); gl::UniformMatrix3fv(normal_loc, 1, gl::FALSE, normal_matrix.as_ptr()); gl::BindVertexArray(node.vao_id); gl::DrawElements(gl::TRIANGLES, node.index_count, gl::UNSIGNED_INT, ptr::null()); } // Recurse to children for &child in &node.children { - draw_scene(&*child, transform_loc, view_projection, &new_transform); + draw_scene(&*child, transform_loc, normal_loc, view_projection, &new_transform); } } -- 2.51.2 From f0e62a6d83b6a63c15a44d8aaa171ca599d9189a Mon Sep 17 00:00:00 2001 From: Adrian Gunnar Lauterer Date: Thu, 2 Oct 2025 12:41:05 +0200 Subject: [PATCH 2/2] Update .gitignore --- .gitignore | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitignore b/.gitignore index 5081f6a..a353884 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,5 @@ *.pdf *.html source.zip - -.aider* flake.lock -- 2.51.2