From 106a955ad126ec6a4a71a8cda0214374c77b680d Mon Sep 17 00:00:00 2001
From: h7x4 <h7x4@nani.wtf>
Date: Thu, 23 Apr 2026 14:13:25 +0900
Subject: [PATCH] finger: smarter `-s`/`-l` defaults

---
 src/bin/finger.rs | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/bin/finger.rs b/src/bin/finger.rs
index 2c23bf3..a9fa2d1 100644
--- a/src/bin/finger.rs
+++ b/src/bin/finger.rs
@@ -1,5 +1,5 @@
 use anyhow::Context;
-use clap::{CommandFactory, Parser};
+use clap::{CommandFactory, Parser, builder::ArgPredicate};
 use clap_complete::{Shell, generate};
 use roowho2_lib::server::varlink_api::VarlinkFingerClientProxy;
 
@@ -92,7 +92,15 @@ pub struct Args {
     /// Mail status is shown as ``No Mail.'' if there is no mail at all,
     /// ``Mail last read DDD MMM ## HH:MM YYYY (TZ)'' if the person has looked at their mailbox since new mail arriving,
     /// or ``New mail received ...'', ``Unread since ...'' if they have new mail.
-    #[arg(long, short, conflicts_with = "short")]
+    #[arg(
+      long,
+      short,
+      conflicts_with = "short",
+      default_value_ifs([
+        ("short", ArgPredicate::IsPresent, "false"),
+        ("users", ArgPredicate::IsPresent, "true"),
+      ]),
+    )]
     long: bool,
 
     /// Prevent the -l option of finger from displaying the contents of
@@ -122,6 +130,11 @@ pub struct Args {
 async fn main() -> anyhow::Result<()> {
     let args = Args::parse();
 
+    debug_assert_ne!(
+        args.short, args.long,
+        "Short and long output formats cannot both be enabled or both be disabled at the same time"
+    );
+
     if let Some(shell) = args.completions {
         generate(shell, &mut Args::command(), "rwho", &mut std::io::stdout());
         return Ok(());